Page MenuHomePhorge

FileUpload: show File page instead of binary file

Authored by valerio.bozzolan on Mar 12 2023, 21:08.
Referenced Files
Unknown Object (File)
Wed, May 31, 06:05
Unknown Object (File)
Apr 30 2023, 19:21
Unknown Object (File)
Apr 25 2023, 05:05
Unknown Object (File)
Apr 21 2023, 09:53
Unknown Object (File)
Mar 30 2023, 21:17
Unknown Object (File)
Mar 30 2023, 13:29
Unknown Object (File)
Mar 30 2023, 11:25
Unknown Object (File)
Mar 30 2023, 00:51



This modification improves a single link shown to the user.

The goal is to make it easier to change file permissions or
file name or whatever just after the upload of the file itself.

Before this change, doing that was difficult because clicking
on the popup would send you back to the binary file only.

Closes T15165

Test Plan
  • upload a file using drag & drop (for example in a comment)
  • click on the popup's link
  • you see the File page, not the binary file

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

avivey added inline comments.

I think we call these "monograms".

rename getPageID() to getMonogram() and add few inline comments

This revision is now accepted and ready to land.Mar 17 2023, 08:06