Page MenuHomePhorge

FileUpload: show File page instead of binary file
ClosedPublic

Authored by valerio.bozzolan on Mar 12 2023, 21:08.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 23, 13:31
Unknown Object (File)
Fri, Feb 23, 13:20
Unknown Object (File)
Fri, Feb 23, 12:55
Unknown Object (File)
Fri, Feb 23, 12:47
Unknown Object (File)
Fri, Feb 23, 06:11
Unknown Object (File)
Fri, Feb 9, 17:46
Unknown Object (File)
Fri, Feb 9, 01:06
Unknown Object (File)
Fri, Feb 9, 01:06

Details

Summary

This modification improves a single link shown to the user.

The goal is to make it easier to change file permissions or
file name or whatever just after the upload of the file itself.

Before this change, doing that was difficult because clicking
on the popup would send you back to the binary file only.

Closes T15165

Test Plan
  • upload a file using drag & drop (for example in a comment)
  • click on the popup's link
  • you see the File page, not the binary file

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey added inline comments.
webroot/rsrc/js/core/FileUpload.js
41

I think we call these "monograms".

rename getPageID() to getMonogram() and add few inline comments

This revision is now accepted and ready to land.Mar 17 2023, 08:06