I had to rebase and rebuild resources/celerity/map.php to fix a merge conflict. I hope that worked.

Oh, I have to land it… Let's see if I still remember how.

I guess this is still waiting for someone to review it, and not for me to "land" it?

I had no idea that I am supposed to "land" these changes. Surely it should be the responsibility of the maintainers to decide into which release a change will go and when?

Lint

Restored the previous selectors, added some code comments to try to explain better why I wrote them this way. I hope this clarifies things. Thanks!

Tweaks per review

Forgot the celerity thing

Added .device-desktop to some selectors as requested

In D25305#10771, @valerio.bozzolan wrote:

Can you share a nice A/B test on Microsoft Windows to upload?

Okay, that's better, some of the failures were real-ish. The remaining ones look like either incompatibilities with Windows in other code that I am not touching here, or issues due to having a different version of a linter installed than expected.

Improve error messages when a binary is missing

I am not sure if these build failures are real? I guess they are from the run on my own machine, which indeed failed on a bunch of tests, but that might be just because I don't have every linter installed? If they are real, I'd appreciate some help investigating them.

Sorry this took me a while to get back to. I was distracted at first, and then it turned out that the lints don't work at all on Windows. (I got them working; I'll file another bug and submit a patch for that.)

Fixed lint issues

I couldn't get it to work (I was missing some dependency for the lint checks), but maybe I'll put in some more effort and try again.

Oh, if your OS doesn't always show scrollbars, then I guess this wouldn't make a difference for you. There's probably an option somewhere to change that, if you wanted to test how it works for others. But this means that my proposed change shouldn't affect you either. :)

Firefox 115, Chromium 114, on Windows 10. Can you share screenshots from Firefox and Chromium on your device?