Page MenuHomePhorge
Feed Advanced Search

Apr 14 2023

valerio.bozzolan updated the task description for T15250: Raw use of "git diff" provides insufficient Diff Context.
Apr 14 2023, 14:13 · Affects-FreeBSD, Differential
ton added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

@valerio.bozzolan yes, https://gitpull.it/D110 demonstrates the point I was trying to communicate. No buttons available to expand the context.

Apr 14 2023, 14:11 · Affects-FreeBSD, Differential
meena added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

So if I understand correctly:

  1. most FreeBSD users share a Diff but is usually just a git patch
    • → first problem: Phorge was intended to use arc diff for best experience, so that to create a git patch, create the Diff, and assign that Diff to the right Repository, run Lint, and run Unit tests
    • → but sharing a raw git patch is really OK and reasonable, I understand that Arcanist is a pain for new users, but:
Apr 14 2023, 11:58 · Affects-FreeBSD, Differential
valerio.bozzolan triaged T15252: Using a raw git diff asks for repository, then loses it as Normal priority.
Apr 14 2023, 09:13 · UX, Differential
avivey added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
In T15249#6218, @ton wrote:

I don't mind if someone points me at the right place in code so I can try my luck with writing PHP.

Apr 14 2023, 08:59 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

By the way, it seems to me that the reporter is saying that these buttons are sometime not available (when the user does not use Arcanist):

Apr 14 2023, 08:43 · Affects-FreeBSD, Differential
avivey added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

As an alternative to using the "upload raw diff" option, see also https://secure.phabricator.com/T5000, and in specific the "magic ref" stuff in T15096#2329 and https://secure.phabricator.com/D9599.

Apr 14 2023, 08:39 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

Feel free to say to me that I probably didn't understand shit as usual :D

Apr 14 2023, 08:29 · Affects-FreeBSD, Differential
valerio.bozzolan renamed T15250: Raw use of "git diff" provides insufficient Diff Context from Insufficient Diff Context to Raw use of "git diff" provides insufficient Diff Context.
Apr 14 2023, 08:25 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

So if I understand correctly:

Apr 14 2023, 08:17 · Affects-FreeBSD, Differential
meena added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

what's frustrating here is the fact that Phorge has the source code, so it should know the context.
But by not providing the context itself, it can also not know when a Diff has diverged and can no longer be landed without (manual) intervention.

Apr 14 2023, 07:57 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

By the way it seems that - for any frontend string - your local Administrators can override a message from the Phorge/Phabricator Config page.

Apr 14 2023, 06:39 · Affects-FreeBSD, Differential
valerio.bozzolan added a comment to T15250: Raw use of "git diff" provides insufficient Diff Context.

Hi, thanks for this interesting question.

Apr 14 2023, 06:22 · Affects-FreeBSD, Differential
ton created T15250: Raw use of "git diff" provides insufficient Diff Context.
Apr 14 2023, 03:15 · Affects-FreeBSD, Differential

Apr 13 2023

ton renamed T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends from Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL to Generate [From, Subject, Date] fields in download raw .diff URL.
Apr 13 2023, 23:32 · Affects-FreeBSD, Differential
ton updated subscribers of T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Apr 13 2023, 23:31 · Affects-FreeBSD, Differential
ton added a comment to T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.

I don't mind if someone points me at the right place in code so I can try my luck with writing PHP.

Apr 13 2023, 23:29 · Affects-FreeBSD, Differential
ton created T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
Apr 13 2023, 23:23 · Affects-FreeBSD, Differential
ton closed Q47: Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL as invalid.
Apr 13 2023, 23:21 · Differential
ton asked Q47: Genrate `From:`, `Subject:` and `Date` fields in download raw .diff URL.
Apr 13 2023, 23:20 · Differential

Apr 6 2023

avivey edited projects for T15128: Differential: Allow to change "Default Edit Policy", added: Policy; removed Policy (archived).
Apr 6 2023, 11:11 · Spam mitigation, Policy, Differential, User-Cigaryno
avivey edited projects for T15131: Add Workboards support for Differential, added: Differential; removed Differential (archived).
Apr 6 2023, 10:44 · Clarification Needed, Differential, Workboard, User-Cigaryno
avivey edited projects for T15170: Allow to edit Differential "inline comments", added: Differential; removed Differential (archived).
Apr 6 2023, 10:44 · Differential, User-valerio.bozzolan
avivey edited projects for T15128: Differential: Allow to change "Default Edit Policy", added: Differential; removed Differential (archived).
Apr 6 2023, 10:44 · Spam mitigation, Policy, Differential, User-Cigaryno
avivey edited projects for T15039: Add a button to copy key information, added: Differential; removed Differential (archived).
Apr 6 2023, 10:44 · Differential
avivey edited projects for T15133: Differential List View should show Repository, added: Differential; removed Differential (archived).
Apr 6 2023, 10:44 · Differential
avivey created Differential.
Apr 6 2023, 10:43