Page MenuHomePhorge

PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup
ClosedPublic

Authored by aklapper on May 19 2023, 15:13.
Tags
None
Referenced Files
F2943627: D25232.1738210015.diff
Wed, Jan 29, 04:06
F2933272: D25232.1737758325.diff
Thu, Jan 23, 22:38
F2931508: D25232.1737711099.diff
Thu, Jan 23, 09:31
F2931501: D25232.1737710805.diff
Thu, Jan 23, 09:26
F2931499: D25232.1737710750.diff
Thu, Jan 23, 09:25
F2931272: D25232.1737701327.diff
Thu, Jan 23, 06:48
F2930709: D25232.1737684144.diff
Thu, Jan 23, 02:02
F2929970: D25232.1737669718.diff
Wed, Jan 22, 22:01

Details

Summary

This is a small fix in a specific user message example. See other messages in the very same file which also use <tt>.

Here the problematic phrase:

Auth screenshot Remarkup problem.png (204×759 px, 24 KB)

See the example in the phrase "Use lowercase letters, digits, and periods. For example: ...".

Test Plan

After this change, the specific message "The URI where the OAuth server is installed. For example" from the page /auth/config/edit/?provider=PhabricatorPhabricatorAuthProvider does not have anymore backticks shown to the end user.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(I have a déjà vu about this patch, I do not know why)

Thanks so much. Just for more context, here the fixed thing:

Phorge Auth fixed.png (259×1 px, 32 KB)

Tested locally following the test plan, nothing explodes.

To test that, I had to destroy my local Auth configuration to have a clean environment. I've done that with:

DELETE FRom auth_providerconfig WHERE providerClass != 'PhabricatorPasswordAuthProvider';

lgtm

This revision is now accepted and ready to land.May 19 2023, 18:24