Page MenuHomePhorge

PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup
ClosedPublic

Authored by aklapper on May 19 2023, 15:13.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 08:37
Unknown Object (File)
Tue, Mar 26, 08:37
Unknown Object (File)
Tue, Mar 26, 07:57
Unknown Object (File)
Tue, Mar 26, 07:28
Unknown Object (File)
Sun, Mar 24, 06:44
Unknown Object (File)
Wed, Mar 20, 10:46
Unknown Object (File)
Feb 25 2024, 07:37
Unknown Object (File)
Feb 25 2024, 07:37

Details

Summary

This is a small fix in a specific user message example. See other messages in the very same file which also use <tt>.

Here the problematic phrase:

Auth screenshot Remarkup problem.png (204×759 px, 24 KB)

See the example in the phrase "Use lowercase letters, digits, and periods. For example: ...".

Test Plan

After this change, the specific message "The URI where the OAuth server is installed. For example" from the page /auth/config/edit/?provider=PhabricatorPhabricatorAuthProvider does not have anymore backticks shown to the end user.

Diff Detail

Repository
rP Phorge
Branch
oAuthUffRemark (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 419
Build 419: arc lint + arc unit

Event Timeline

(I have a déjà vu about this patch, I do not know why)

Thanks so much. Just for more context, here the fixed thing:

Phorge Auth fixed.png (259×1 px, 32 KB)

Tested locally following the test plan, nothing explodes.

To test that, I had to destroy my local Auth configuration to have a clean environment. I've done that with:

DELETE FRom auth_providerconfig WHERE providerClass != 'PhabricatorPasswordAuthProvider';

lgtm

This revision is now accepted and ready to land.May 19 2023, 18:24