Page MenuHomePhorge

PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup
ClosedPublic

Authored by aklapper on May 19 2023, 15:13.
Tags
None
Referenced Files
F3329451: D25232.1743475307.diff
Mon, Mar 31, 02:41
F3328212: D25232.1743451833.diff
Sun, Mar 30, 20:10
F3328200: D25232.1743451654.diff
Sun, Mar 30, 20:07
F3323682: D25232.1743388529.diff
Sun, Mar 30, 02:35
F3322301: D25232.1743369165.diff
Sat, Mar 29, 21:12
F3321772: D25232.1743360316.diff
Sat, Mar 29, 18:45
F3318412: D25232.1743282687.diff
Fri, Mar 28, 21:11
F3316614: D25232.1743252983.diff
Fri, Mar 28, 12:56

Details

Summary

This is a small fix in a specific user message example. See other messages in the very same file which also use <tt>.

Here the problematic phrase:

Auth screenshot Remarkup problem.png (204×759 px, 24 KB)

See the example in the phrase "Use lowercase letters, digits, and periods. For example: ...".

Test Plan

After this change, the specific message "The URI where the OAuth server is installed. For example" from the page /auth/config/edit/?provider=PhabricatorPhabricatorAuthProvider does not have anymore backticks shown to the end user.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(I have a déjà vu about this patch, I do not know why)

Thanks so much. Just for more context, here the fixed thing:

Phorge Auth fixed.png (259×1 px, 32 KB)

Tested locally following the test plan, nothing explodes.

To test that, I had to destroy my local Auth configuration to have a clean environment. I've done that with:

DELETE FRom auth_providerconfig WHERE providerClass != 'PhabricatorPasswordAuthProvider';

lgtm

This revision is now accepted and ready to land.May 19 2023, 18:24