Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page
ClosedPublic
Actions

Authored by aklapper on Apr 29 2023, 20:14.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15296: PHP 8.1 "strlen(null)" exception blocks rendering the Home page

Commits

rPf8ae17bb6a1e: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15296

Test Plan

Applied this change and Home page rendered in web browser.

Diff Detail

Repository

rP Phorge

Branch

homepageRender (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 289
Build 289: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 29 2023, 20:14

Owners added a reviewer: O1: Blessed Committers.Apr 29 2023, 20:14

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 29 2023, 20:14

aklapper requested review of this revision.Apr 29 2023, 20:14

Harbormaster completed remote builds in B289: Diff 555.Apr 29 2023, 20:14

aklapper mentioned this in D25150: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page.Apr 30 2023, 08:08

aklapper mentioned this in rP1b8294341916: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page.Apr 30 2023, 13:13

valerio.bozzolan mentioned this in D25161: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog.Apr 30 2023, 22:52

aklapper mentioned this in rPe3ad37f79259: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public….Apr 30 2023, 23:08

valerio.bozzolan mentioned this in D25152: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task creation page.May 1 2023, 08:16

valerio.bozzolan mentioned this in D25162: Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects.May 1 2023, 08:21

valerio.bozzolan mentioned this in D25153: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page (and log alien values).May 1 2023, 08:37

Tested locally. No nuclear implosions. Thanks!

yesyes

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php
29	✅ I debugged `$name` locally with `phlog()` to verify that it only assumes string or null, for example using the Edit Menu Item and similar stuff with fuzzy data. The `phutil_nonempty_string()` will report alien values and that is OK.