Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog
ClosedPublic

Authored by aklapper on Apr 30 2023, 18:15.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 14, 05:59
Unknown Object (File)
Sun, Jul 14, 05:59
Unknown Object (File)
Sun, Jul 14, 05:58
Unknown Object (File)
Sun, Jul 14, 00:53
Unknown Object (File)
Sat, Jul 13, 02:50
Unknown Object (File)
Mon, Jul 8, 22:28
Unknown Object (File)
Mon, Jul 8, 22:24
Unknown Object (File)
Mon, Jul 8, 22:09

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15311

Test Plan

Applied this change (on top of D25144, D25145, D25146, D25147, D25151,
D25152, D25153) and Upload SSH Public key dialog rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks

Tested locally creating SSH key with and without a name. No implosions! Yuppie!

yesyes

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php
57

✅ I checked $v_name with phlog() to verify that the input domain was null or a string. The phutil_nonempty_string() will report alien values and that is OK.

This revision is now accepted and ready to land.Apr 30 2023, 20:48