Ref T15046
Details
Details
- Reviewers
Cigaryno valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15046: Add GitHub mirrors for repos
- Commits
- rP187da02ecd23: Add GitHub mirror to list of known mirrors
rPd46aab832118: Add GitHub mirror to list of known mirrors
Clone phorge from github mirror, visit /config/, see correct branch-point in Version Information
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- phorge (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 230 Build 230: arc lint + arc unit
Event Timeline
Comment Actions
Honestly I cannot test since - in both cases - in my local installation that section is just empty:
Any tip?
Comment Actions
Honestly I cannot test since - in both cases - in my local installation that section is just empty:
Any tip?
maybe we need to add some logs here for debugging, I had a hard time testing it myself.
It runs git remote -v to find the remotes, and then checks each one against this whitelist.
It picks either origin or the first matching remote, and runs git merge-base HEAD <remote>/master.
If any of that fails, it produces nothing.
It's possible that these commands will fail due to the www user not having access to read the config (in newer git clients - unsafe repository?).
There's similar code in the exception handling code - do you get git information in exceptions?
Comment Actions
Thank you for this useful and totally correct stuff.
Let's move these discussions here:
T15242: /config/ can run git log commands that silently fail ("fatal: detected dubious ownership in repository at ....")
T15243: The /config/ page should log git errors instead of silently ignore them
About this change, thank you and green light for me. Tested successfully.