Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F3090163: D25098.1741090312.diff
Mon, Mar 3, 12:11
F2981830: D25098.1739938514.diff
Tue, Feb 18, 04:15
F2963712: D25098.1739217609.diff
Sun, Feb 9, 20:00
F2963483: D25098.1739215150.diff
Sun, Feb 9, 19:19
F2963482: D25098.1739215145.diff
Sun, Feb 9, 19:19
F2963481: D25098.1739215140.diff
Sun, Feb 9, 19:19
F2959854: D25098.1739138408.diff
Feb 8 2025, 22:00
F2946891: D25098.1738427186.diff
Jan 31 2025, 16:26
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.