Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 03:23
Unknown Object (File)
Sat, Apr 6, 03:49
Unknown Object (File)
Apr 1 2024, 01:04
Unknown Object (File)
Apr 1 2024, 01:04
Unknown Object (File)
Apr 1 2024, 01:04
Unknown Object (File)
Mar 27 2024, 03:05
Unknown Object (File)
Mar 27 2024, 01:48
Unknown Object (File)
Mar 24 2024, 06:03
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Branch
PHP8.2-T15196-var-in-strings
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 189
Build 189: arc lint + arc unit

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.