Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F3605487: D25098.1745272537.diff
Sun, Apr 20, 21:55
F3605192: D25098.1745256616.diff
Sun, Apr 20, 17:30
F3605096: D25098.1745251538.diff
Sun, Apr 20, 16:05
F3554186: D25098.1744977535.diff
Thu, Apr 17, 11:58
F3527300: D25098.1744838955.diff
Tue, Apr 15, 21:29
F3406834: D25098.1744586628.diff
Sat, Apr 12, 23:23
F3400951: D25098.1744562048.diff
Sat, Apr 12, 16:34
F3383064: D25098.1744380425.diff
Thu, Apr 10, 14:07
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Branch
PHP8.2-T15196-var-in-strings
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 189
Build 189: arc lint + arc unit

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.