Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F4225922: D25098.1747242163.diff
Tue, May 13, 17:02
F4201996: D25098.1747222065.diff
Tue, May 13, 11:27
F4201995: D25098.1747222062.diff
Tue, May 13, 11:27
F4110524: D25098.1746916240.diff
Fri, May 9, 22:30
F4047497: D25098.1746746913.diff
Wed, May 7, 23:28
F4032943: D25098.1746710179.diff
Wed, May 7, 13:16
F3970288: D25098.1746526814.diff
Mon, May 5, 10:20
F3968831: D25098.1746521520.diff
Mon, May 5, 08:52
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Branch
PHP8.2-T15196-var-in-strings
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 189
Build 189: arc lint + arc unit

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.