Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F3220469: D25098.1741810179.diff
Tue, Mar 11, 20:09
F3220468: D25098.1741810176.diff
Tue, Mar 11, 20:09
F3220467: D25098.1741810173.diff
Tue, Mar 11, 20:09
F3220466: D25098.1741810169.diff
Tue, Mar 11, 20:09
F3090163: D25098.1741090312.diff
Mon, Mar 3, 12:11
F2981830: D25098.1739938514.diff
Tue, Feb 18, 04:15
F2963712: D25098.1739217609.diff
Feb 9 2025, 20:00
F2963483: D25098.1739215150.diff
Feb 9 2025, 19:19
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Branch
PHP8.2-T15196-var-in-strings
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 189
Build 189: arc lint + arc unit

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.