Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup
ClosedPublic
Actions

Authored by Ekubischta on Jun 25 2021, 22:24.

Details

Reviewers

deadalnix
eax
speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15021: Exclude the Aphlict package-lock.json from linting rule

Commits

rP69cb76092142: Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup

Summary

Aphlict requires a machine generated package-lock.json that can trigger linters unnecessarily.

This revision excludes it from all linters

Test Plan

Testing

Fake Change to set off the linter

diff --git a/support/aphlict/server/package-lock.json b/support/aphlict/server/package-lock.json
index 8af62ae233..a417725182 100644
--- a/support/aphlict/server/package-lock.json
+++ b/support/aphlict/server/package-lock.json
@@ -2,11 +2,12 @@
   "name": "aphlict-server",
   "requires": true,
   "lockfileVersion": 1,
+  "testing" : true,
   "dependencies": {
     "ws": {
       "version": "7.5.0",
       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
-      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgi4vw=="
+      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
     }
   }
 }

arc lint results

root@63c842bff39e:/srv/phorge/phorge# arc lint
>>> Lint for support/aphlict/server/package-lock.json:


   Warning  (TXT3) Line Too Long
    This line is 156 characters long, but the convention is 80 characters.

               7     "ws": {
               8       "version": "7.5.0",
               9       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
    >>>       10       "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
              11     }
              12   }
              13 }
root@63c842bff39e:/srv/phorge/phorge#

Updated change

Change to .arclint

diff --git a/.arclint b/.arclint
index f215d93fdc..ca89c601e4 100644
--- a/.arclint
+++ b/.arclint
@@ -2,7 +2,8 @@
   "exclude": [
     "(^externals/)",
     "(^webroot/rsrc/externals/(?!javelin/))",
-    "(/__tests__/data/)"
+    "(/__tests__/data/)",
+    "(^support/aphlict/server/package-lock.json)"
   ],
   "linters": {
     "chmod": {

arc lint results

root@63c842bff39e:/srv/phorge/phorge# arc lint
 OKAY  No lint messages.
root@63c842bff39e:/srv/phorge/phorge#

Diff Detail

Repository

rP Phorge

Branch

T15021-Exclude_Aphlict_PackageJson_From_Lint

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27
Build 27: arc lint + arc unit

Event Timeline

Ekubischta created this revision.Jun 25 2021, 22:24

Owners added a reviewer: O1: Blessed Committers.Jun 25 2021, 22:24

Herald added subscribers: tobiaswiese, speck. · View Herald TranscriptJun 25 2021, 22:24

Ekubischta requested review of this revision.Jun 25 2021, 22:24

Harbormaster completed remote builds in B27: Diff 36.Jun 25 2021, 22:24

We could move this from the global exclude to just the specific linters (like the txt linter, etc.) - That would be a reasonable request

Ekubischta mentioned this in T15021: Exclude the Aphlict package-lock.json from linting rule.Jun 25 2021, 22:27

Ekubischta retitled this revision from Updated .arclint in Phorge to exclude package-lock.json from Sphlict setup to Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup.

deadalnix accepted this revision.Jun 25 2021, 22:41

This revision is now accepted and ready to land.Jun 25 2021, 22:41

eax accepted this revision.Jun 25 2021, 23:25

In D25012#422, @Ekubischta wrote:

We could move this from the global exclude to just the specific linters (like the txt linter, etc.) - That would be a reasonable request

Since the file is auto-generated I think it makes sense to exclude globally

Closed by commit rP69cb76092142: Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup. · Explain WhyJun 26 2021, 15:48

This revision was automatically updated to reflect the committed changes.

Ekubischta added a commit: rP69cb76092142: Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup.