PhpDoc: Replace non-standard dict type with array
ClosedPublic
Actions

Authored by aklapper on Tue, Jun 3, 18:10.

Details

Reviewers

valerio.bozzolan
amybones

Group Reviewers

O1: Blessed Committers

Commits

rP697d08f581b8: PhpDoc: Replace non-standard dict type with array

Summary

Make static code analysis more correct (which does not also mean less noisy) by replacing "dict" and "dictionary" types in PhpDoc with what they actually are: an array.
The "dictionary" type is not mentioned in arcanist/src/parser/PhutilTypeSpec.php either, thus no side effects.

See also related discussions in https://we.phorge.it/D26037 and https://we.phorge.it/D26039#27821

Test Plan

Grep and read the code, use static code analysis.

Diff Detail

Repository

rP Phorge

Branch

phpdocKillDictType (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2074
Build 2074: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Jun 3, 18:10

Owners added a reviewer: O1: Blessed Committers.Tue, Jun 3, 18:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Jun 3, 18:10

aklapper requested review of this revision.Tue, Jun 3, 18:10

Harbormaster completed remote builds in B2052: Diff 3148.Tue, Jun 3, 18:10

What could go wrong

whatcouldgowrong

This revision is now accepted and ready to land.Tue, Jun 3, 20:44

aklapper mentioned this in D26060: PhpDoc: Replace non-standard dict type with array.Wed, Jun 4, 07:55

It's already accepted but yesssss

yesyes

aklapper mentioned this in rARC32ac94aa9958: PhpDoc: Replace non-standard dict type with array.Mon, Jun 9, 08:09

PhpDoc: Replace non-standard pair type with array

Summary:
Make static code analysis more correct (which does not also mean less noisy) by replacing "pair" types in PhpDoc with what they actually are: an array.
The "pair" type is not mentioned in arcanist/src/parser/PhutilTypeSpec.php either, thus no side effects.

Test Plan:
Grep and read the code, use static code analysis.

Harbormaster completed remote builds in B2074: Diff 3186.Mon, Jun 9, 09:32

^^ That was supposed to be a git rebase master (not sure why Arcanist proposed the default commit message instead of a by-default-empty "comment" message)

Closed by commit rP697d08f581b8: PhpDoc: Replace non-standard dict type with array. · Explain WhyMon, Jun 9, 11:26

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP697d08f581b8: PhpDoc: Replace non-standard dict type with array.