Differential D25913

Herald actions: Allow setting subtype on Maniphest tasks
ClosedPublic
Actions

Authored by aklapper on Sat, Mar 22, 10:16.

Tags

None

Referenced Files

	F3323376: D25913.1743385794.diff
	Sun, Mar 30, 01:49

	F3320812: D25913.1743337964.diff
	Sat, Mar 29, 12:32

	F3320139: D25913.1743322343.diff
	Sat, Mar 29, 08:12

	F3308424: D25913.1743166527.diff
	Thu, Mar 27, 12:55

	F3307660: D25913.1743149944.diff
	Thu, Mar 27, 08:19

	F3305614: D25913.1743117773.diff
	Wed, Mar 26, 23:22

	F3304794: D25913.1743105313.diff
	Wed, Mar 26, 19:55

	F3303250: D25913.1743079417.diff
	Wed, Mar 26, 12:43

View All 11 Files

Subscribers

valerio.bozzolan

Tokens

"Like" token, awarded by 20after4.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16022: Herald: Support setting task subtype action

Commits

rP56797b17ede0: Herald actions: Allow setting subtype on Maniphest tasks

Summary

https://secure.phabricator.com/T12314 introduced task subtypes. Allow Herald rules which change/set the subtype of a task.
Code originally written by @20after4 for Wikimedia.

Closes T16022

Test Plan

Have the default subtype configuration with three types under http://phorge.localhost/config/edit/maniphest.subtypes/ defined in src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
Go to http://phorge.localhost/herald/edit/?content_type=HeraldManiphestTaskAdapter&rule_type=global
Under "Action", select the new "Change subtype to" option. Test the subtype search by clicking the magnifier icon, set up a Herald rule to test execution.
Remove the config for http://phorge.localhost/config/edit/maniphest.subtypes/
Repeat step 3, no explosions, default "Task" subtype still exists after removing the config.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sat, Mar 22, 10:16

Owners added a reviewer: O1: Blessed Committers.Sat, Mar 22, 10:16

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Mar 22, 10:16

aklapper requested review of this revision.Sat, Mar 22, 10:16

Harbormaster completed remote builds in B1788: Diff 2753.Sat, Mar 22, 10:16

It works on my computer and it makes me feel like a happy Phorgi unicorn running in a Phorgi golden forest, whoa

This revision is now accepted and ready to land.Sat, Mar 22, 21:40

Closed by commit rP56797b17ede0: Herald actions: Allow setting subtype on Maniphest tasks. · Explain WhyTue, Mar 25, 09:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP56797b17ede0: Herald actions: Allow setting subtype on Maniphest tasks.

aklapper mentioned this in Next Up.Tue, Mar 25, 09:35

20after4 awarded a token.Tue, Mar 25, 13:55

Revision Contents
Changeset List

Path

Size

Packages

src/

__phutil_library_map__.php

O1: Blessed Committers

applications/

maniphest/

herald/

SetSubtypeHeraldAction.php

74 lines

O1: Blessed Committers

Diff 2776

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/herald/SetSubtypeHeraldAction.php

Loading...