Page MenuHomePhorge

Update arcanist readme to reference Phorge
ClosedPublic

Authored by Matthew on Jun 20 2021, 01:05.
Tags
None
Referenced Files
F3926775: D25009.1746369484.diff
Sat, May 3, 14:38
F3805066: D25009.1745986923.diff
Tue, Apr 29, 04:22
F3800499: D25009.1745934733.diff
Mon, Apr 28, 13:52
F3800487: D25009.1745934094.diff
Mon, Apr 28, 13:41
F3780131: D25009.1745893800.diff
Mon, Apr 28, 02:30
F3762291: D25009.1745832934.diff
Sun, Apr 27, 09:35
F3754849: D25009.1745825068.diff
Sun, Apr 27, 07:24
F3646751: D25009.1745394856.diff
Tue, Apr 22, 07:54

Details

Reviewers
20after4
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15006: Re-brand Phorge
Test Plan

Looked at the rendered markdown.

Diff Detail

Repository
rARC Arcanist
Branch
T15006-1
Lint
Lint Warnings
SeverityLocationCodeMessage
WarningREADME.md:4TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 20
Build 20: arc lint + arc unit

Event Timeline

Matthew requested review of this revision.Jun 20 2021, 01:05

Fix a link that will break once we regenerate the documentation.

eax added inline comments.
README.md
2

This line as well?

20after4 subscribed.

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

This revision is now accepted and ready to land.Jun 20 2021, 12:24
README.md
6

How about changing the protocol to https?

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

Not sure the answer to that one... Would you like to open a task to discuss?

Address code review comments

This revision was landed with ongoing or failed builds.Jun 20 2021, 21:20
This revision was automatically updated to reflect the committed changes.