Page MenuHomePhorge

Update arcanist readme to reference Phorge
ClosedPublic

Authored by Matthew on Jun 20 2021, 01:05.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 15:54
Unknown Object (File)
Mon, Mar 18, 20:31
Unknown Object (File)
Mon, Mar 18, 03:08
Unknown Object (File)
Thu, Mar 14, 08:16
Unknown Object (File)
Thu, Mar 14, 08:16
Unknown Object (File)
Thu, Mar 14, 08:16
Unknown Object (File)
Thu, Mar 14, 08:16
Unknown Object (File)
Thu, Mar 14, 07:57

Details

Reviewers
20after4
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15006: Re-brand Phorge
Test Plan

Looked at the rendered markdown.

Diff Detail

Repository
rARC Arcanist
Branch
T15006-1
Lint
Lint Warnings
SeverityLocationCodeMessage
WarningREADME.md:4TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 21
Build 21: arc lint + arc unit

Event Timeline

Matthew requested review of this revision.Jun 20 2021, 01:05

Fix a link that will break once we regenerate the documentation.

eax added inline comments.
README.md
1–2

This line as well?

20after4 subscribed.

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

This revision is now accepted and ready to land.Jun 20 2021, 12:24
README.md
6

How about changing the protocol to https?

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

Not sure the answer to that one... Would you like to open a task to discuss?

Address code review comments

This revision was landed with ongoing or failed builds.Jun 20 2021, 21:20
This revision was automatically updated to reflect the committed changes.