Page MenuHomePhorge
Differential D25009

Update arcanist readme to reference Phorge
ClosedPublic
Actions

Authored by Matthew on Jun 20 2021, 01:05.
Tags
None
Referenced Files
F2156291: D25009.id25.diff
Tue, Apr 23, 16:32
F2154323: D25009.id25.diff
Mon, Apr 22, 20:43
F2154322: D25009.id26.diff
Mon, Apr 22, 20:43
F2154321: D25009.id27.diff
Mon, Apr 22, 20:43
F2154320: D25009.id24.diff
Mon, Apr 22, 20:43
F2154226: D25009.id.diff
Mon, Apr 22, 19:08
F2154199: D25009.diff
Mon, Apr 22, 18:48
Unknown Object (File)
Mon, Apr 22, 10:45
View All Files
Subscribers
20after4
eax
speck
tobiaswiese

Details

Reviewers
20after4
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15006: Re-brand Phorge
Test Plan

Looked at the rendered markdown.

Diff Detail

Repository
rARC Arcanist
Branch
T15006-1
Lint
Lint Warnings
SeverityLocationCodeMessage
WarningREADME.md:4TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 20
Build 20: arc lint + arc unit

Event Timeline

Matthew created this revision.Jun 20 2021, 01:05
Owners added a reviewer: O1: Blessed Committers.Jun 20 2021, 01:05
Herald added subscribers: tobiaswiese, speck. · View Herald TranscriptJun 20 2021, 01:05
Matthew requested review of this revision.Jun 20 2021, 01:05
Harbormaster completed remote builds in B19: Diff 24.Jun 20 2021, 01:05
Matthew updated this revision to Diff 25.Jun 20 2021, 01:07

Fix a link that will break once we regenerate the documentation.

Harbormaster completed remote builds in B20: Diff 25.Jun 20 2021, 01:07
eax subscribed.Jun 20 2021, 07:09
eax added inline comments.
README.md
2

This line as well?

20after4 accepted this revision.Jun 20 2021, 12:24
20after4 subscribed.

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

This revision is now accepted and ready to land.Jun 20 2021, 12:24
tobiaswiese added inline comments.Jun 20 2021, 15:30
README.md
6

How about changing the protocol to https?

Matthew marked 2 inline comments as done.Jun 20 2021, 21:19
In D25009#285, @20after4 wrote:

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

Not sure the answer to that one... Would you like to open a task to discuss?

Matthew updated this revision to Diff 26.Jun 20 2021, 21:20

Address code review comments

Harbormaster completed remote builds in B21: Diff 26.Jun 20 2021, 21:20
This revision was landed with ongoing or failed builds.Jun 20 2021, 21:20
Closed by commit rARC7498c10215be: Update arcanist readme to reference Phorge. · Explain Why
This revision was automatically updated to reflect the committed changes.
Matthew added a commit: rARC7498c10215be: Update arcanist readme to reference Phorge.
Chucky removed a commit: rARC7498c10215be: Update arcanist readme to reference Phorge.Aug 13 2021, 20:35

Revision Contents
Changeset List

PathSizePackages
6 linesO1: Blessed Committers

Diff 25

View Options

README.md

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0