Differential D25009

Update arcanist readme to reference Phorge
ClosedPublic
Actions

Authored by Matthew on Jun 20 2021, 01:05.

Details

Reviewers

20after4

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15006: Re-brand Phorge

Test Plan

Looked at the rendered markdown.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Matthew created this revision.Jun 20 2021, 01:05

Owners added a reviewer: O1: Blessed Committers.Jun 20 2021, 01:05

Herald added subscribers: tobiaswiese, speck. · View Herald TranscriptJun 20 2021, 01:05

Matthew requested review of this revision.Jun 20 2021, 01:05

Harbormaster completed remote builds in B19: Diff 24.Jun 20 2021, 01:05

Fix a link that will break once we regenerate the documentation.

Harbormaster completed remote builds in B20: Diff 25.Jun 20 2021, 01:07

eax subscribed.Jun 20 2021, 07:09

eax added inline comments.

README.md
1–2	This line as well?

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

This revision is now accepted and ready to land.Jun 20 2021, 12:24

tobiaswiese added inline comments.Jun 20 2021, 15:30

README.md
6	How about changing the protocol to https?

In D25009#285, @20after4 wrote:

Shouldn't we also think about changing the name of arcanist or does it make sense to have a fork with the same name?

Not sure the answer to that one... Would you like to open a task to discuss?

Address code review comments

Harbormaster completed remote builds in B21: Diff 26.Jun 20 2021, 21:20

This revision was landed with ongoing or failed builds.Jun 20 2021, 21:20

Closed by commit rARC7498c10215be: Update arcanist readme to reference Phorge. · Explain Why

This revision was automatically updated to reflect the committed changes.

Matthew added a commit: rARC7498c10215be: Update arcanist readme to reference Phorge.

Chucky removed a commit: rARC7498c10215be: Update arcanist readme to reference Phorge.Aug 13 2021, 20:35

Revision Contents
Changeset List

Path

Size

Packages

README.md

8 lines

O1: Blessed Committers

Diff 27

View Options

Update arcanist readme to reference PhorgeClosedPublicActions