Per https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md the valid keyword is $this.
Thus replace this to make output of static code analysis slightly less noisy.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rARC4b7ee1985b3c: PHPDoc: Replace "@return this" with "@return $this"
Read the docs.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- returnThis
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 1582 Build 1582: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 678 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'.
#0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(85): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture))
#1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
| |
| 99 ms | ArcanistXMLLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "languages-6.lint-test".
MISSING MESSAGES
Message with severity "error" at "4:1" (XML5)
| |
| 75 ms | AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed. | |
| 76 ms | AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed. | |
| 75 ms | AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed. | |
| View Full Test Results (2 Failed · 284 Passed · 32 Skipped) |
Event Timeline
Comment Actions
(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl