Paths

Table of Contentst

Differential D25818

PHPDoc: Replace "@return this" with "@return $this"
ClosedPublic
Actions

Authored by aklapper on Sep 5 2024, 15:21.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC4b7ee1985b3c: PHPDoc: Replace "@return this" with "@return $this"

Summary

Per https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md the valid keyword is $this.
Thus replace this to make output of static code analysis slightly less noisy.

Test Plan

Read the docs.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Sep 5 2024, 15:21

Owners added a reviewer: O1: Blessed Committers.Sep 5 2024, 15:21

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSep 5 2024, 15:21

aklapper requested review of this revision.Sep 5 2024, 15:21

Harbormaster completed remote builds in B1582: Diff 2454.Sep 5 2024, 15:21

(In general thanks and please do whatever needed change in PHPDoc but let's reduce the commits on single files for different PHPDoc changes; so if you have lot of warnings on a single file, just do them all thanksl

PHPDoc: Replace "@return this" with "@return $this"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2457

src/channel/PhutilChannel.php

src/channel/PhutilExecChannel.php

src/channel/PhutilProtocolChannel.php

src/console/view/PhutilConsoleView.php

src/filesystem/FileFinder.php

src/filesystem/FileList.php

src/filesystem/PhutilDeferredLog.php

src/filesystem/PhutilLock.php

src/filesystem/TempFile.php

src/filesystem/linesofalarge/LinesOfALarge.php

src/future/FutureIterator.php

src/future/exec/ExecFuture.php

src/future/exec/PhutilExecutableFuture.php

src/future/http/BaseHTTPFuture.php

src/future/http/HTTPSFuture.php

src/hgdaemon/ArcanistHgProxyClient.php

src/hgdaemon/ArcanistHgProxyServer.php

src/lint/engine/ArcanistLintEngine.php

src/lint/linter/ArcanistExternalLinter.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/ArcanistXHPASTLinter.php

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

src/moduleutils/PhutilLibraryMapBuilder.php

src/parser/PhutilSimpleOptions.php

src/parser/argument/PhutilArgumentParser.php

src/repository/api/ArcanistRepositoryAPI.php

src/symbols/PhutilClassMapQuery.php

src/symbols/PhutilSymbolLoader.php

src/unit/ArcanistUnitTestResult.php

src/upload/ArcanistFileDataRef.php

src/upload/ArcanistFileUploader.php

src/utils/AbstractDirectedGraph.php

src/utils/PhutilBufferedIterator.php

src/utils/PhutilRope.php

src/workflow/ArcanistWorkflow.php

PHPDoc: Replace "@return this" with "@return $this"
ClosedPublic
Actions

Revision Contents
Changeset List