Page MenuHomePhorge

Redirect back to object after clicking "Log In to Comment" and login
ClosedPublic

Authored by aklapper on May 20 2024, 16:47.

Details

Summary

PhabricatorApplicationTransactionCommentView performs $uri = id(new PhutilURI('/login/'))->replaceQueryParam('next', (string)$this->getRequestURI()) but the constructor call in PhabricatorEditEngine does not set any RequestURI so the Log In to Comment button at the bottom of an object view does not redirect back to the object URI after login.

Thus pass a RequestURI to PhabricatorApplicationTransactionCommentView in the constructor call in PhabricatorEditEngine.

Closes T15837

Test Plan

As a Phorge admin, set policy.allow-public to true and create a Maniphest task with Public view policy. As an anonymous user, visit the task and click the Log In to Comment button at the bottom of the single task view, log in, and see that you get redirected to the task.

Diff Detail

Repository
rP Phorge
Branch
redirectLoginComment (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1293
Build 1293: arc lint + arc unit