Page MenuHomePhorge

TransactionEditor: micro-optimize the "creation finder"
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 08:32.
Tags
None
Referenced Files
F2945368: D25627.1738313028.diff
Thu, Jan 30, 08:43
F2944561: D25627.1738273085.diff
Wed, Jan 29, 21:38
F2941270: D25627.1738106566.diff
Mon, Jan 27, 23:22
F2938475: D25627.1738000666.diff
Sun, Jan 26, 17:57
F2938388: D25627.1737994412.diff
Sun, Jan 26, 16:13
F2936929: D25627.1737943606.diff
Sun, Jan 26, 02:06
F2934385: D25627.1737786067.diff
Fri, Jan 24, 06:21
F2934384: D25627.1737786065.diff
Fri, Jan 24, 06:21

Details

Summary

The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.

When we have found that, let's stop that loop, so, we save some CPU cycles.

Test Plan

Note that getTransactionType() has not side-effects.

Test some applications - like Pholio - that use the TransactionEditor:

  • Create a new Pholio and Save
  • Save it again without changes.
  • Save it again with changes.

Everything still working normally.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable