Page MenuHomePhorge

TransactionEditor: micro-optimize the "creation finder"
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 08:32.
Tags
None
Referenced Files
F3147995: D25627.1741216757.diff
Tue, Mar 4, 23:19
F3147993: D25627.1741216755.diff
Tue, Mar 4, 23:19
F3147920: D25627.1741216548.diff
Tue, Mar 4, 23:15
F3082808: D25627.1741072531.diff
Mon, Mar 3, 07:15
F2988964: D25627.1740157907.diff
Thu, Feb 20, 17:11
F2978911: D25627.1739721994.diff
Sat, Feb 15, 16:06
F2945368: D25627.1738313028.diff
Jan 30 2025, 08:43
F2944561: D25627.1738273085.diff
Jan 29 2025, 21:38

Details

Summary

The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.

When we have found that, let's stop that loop, so, we save some CPU cycles.

Test Plan

Note that getTransactionType() has not side-effects.

Test some applications - like Pholio - that use the TransactionEditor:

  • Create a new Pholio and Save
  • Save it again without changes.
  • Save it again with changes.

Everything still working normally.

Diff Detail

Repository
rP Phorge
Branch
micro-optimization-create-finder
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1237
Build 1237: arc lint + arc unit