The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.
When we have found that, let's stop that loop, so, we save some CPU cycles.
Details
Details
- Reviewers
aklapper - Group Reviewers
O1: Blessed Committers - Commits
- rPb6f132f04f06: TransactionEditor: micro-optimize the "creation finder"
Note that getTransactionType() has not side-effects.
Test some applications - like Pholio - that use the TransactionEditor:
- Create a new Pholio and Save
- Save it again without changes.
- Save it again with changes.
Everything still working normally.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- micro-optimization-create-finder
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1237 Build 1237: arc lint + arc unit