Page MenuHomePhorge

TransactionEditor: micro-optimize the "creation finder"
ClosedPublic

Authored by valerio.bozzolan on May 9 2024, 08:32.
Tags
None
Referenced Files
F3372746: D25627.1744251834.diff
Wed, Apr 9, 02:23
F3369764: D25627.1744216319.diff
Tue, Apr 8, 16:31
F3368296: D25627.1744207467.diff
Tue, Apr 8, 14:04
F3367435: D25627.1744199949.diff
Tue, Apr 8, 11:59
F3359976: D25627.1743967457.diff
Sat, Apr 5, 19:24
F3359830: D25627.1743958711.diff
Sat, Apr 5, 16:58
F3358188: D25627.1743919855.diff
Sat, Apr 5, 06:10
F3353127: D25627.1743825143.diff
Fri, Apr 4, 03:52

Details

Summary

The foreach starting at old line 1305-1311 was designed to look for a specific transaction type.

When we have found that, let's stop that loop, so, we save some CPU cycles.

Test Plan

Note that getTransactionType() has not side-effects.

Test some applications - like Pholio - that use the TransactionEditor:

  • Create a new Pholio and Save
  • Save it again without changes.
  • Save it again with changes.

Everything still working normally.

Diff Detail

Repository
rP Phorge
Branch
micro-optimization-create-finder
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1237
Build 1237: arc lint + arc unit