Page MenuHomePhorge

Use more css and phorge standard elements for application view
AcceptedPublic

Authored by bekay on May 1 2024, 16:10.

Details

Summary

This diff streamlines the application view. This includes:

  • using the newPage method of the PhabricatorController
  • using the application crumb standard class for rendering of crumbs
  • using 📊 as application glyph
  • using css and flex for sizing of the drawio app iframe (circumvents magic css numbers)
  • implementing some phorge coding standards
Test Plan

Creating and editing diagrams (and older versions) look at the new breadcrumbs. Is everything looking and working as expected?

Diff Detail

Repository
R5 Diagrams
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1212
Build 1212: arc lint + arc unit