Page MenuHomePhorge

Facts: Fix displaying charts for anonymous users
ClosedPublic

Authored by aklapper on Apr 30 2024, 16:02.

Details

Summary

Charts in the Facts prototype application (e.g. as a Burndown chart on a project's Reports page) remained empty for users not logged in: payload response was a login dialog instead of actual data to render. Thus set shouldAllowPublic() (as for many other Controllers).

Closes T15436

Test Plan

Diff Detail

Repository
rP Phorge
Branch
T15436reportChart (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1208
Build 1208: arc lint + arc unit

Event Timeline

avivey subscribed.

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

This revision is now accepted and ready to land.May 5 2024, 14:02

This is probably the right fix (or maybe moving shouldAllowPublic() to the base PhabricatorFactController).

Right... PhabricatorFactController is abstract and the neighbor file fact/controller/PhabricatorFactHomeController.php has the same two lines. So I think we're fine.