Page MenuHomePhorge

Config User Extra Fields: link to the doc (like Maniphest)
ClosedPublic

Authored by valerio.bozzolan on Jan 8 2024, 09:07.
Tags
None
Referenced Files
F2993414: D25507.1740280121.diff
Sat, Feb 22, 03:08
F2993413: D25507.1740280120.diff
Sat, Feb 22, 03:08
F2993412: D25507.1740280118.diff
Sat, Feb 22, 03:08
F2992904: D25507.1740258449.diff
Fri, Feb 21, 21:07
F2992877: D25507.1740255685.diff
Fri, Feb 21, 20:21
F2963131: D25507.1739198091.diff
Sun, Feb 9, 14:34
F2963130: D25507.1739198087.diff
Sun, Feb 9, 14:34
F2961693: D25507.1739169810.diff
Sun, Feb 9, 06:43

Details

Summary

Add a documentation link in a specific Config page, that is:

Config > Setting > user.custom-field-definitions

Test Plan

Visit the page and click on the new link:

  • /config/edit/user.custom-field-definitions/

Visit this page that was the inspirational page:

  • /config/edit/maniphest.custom-field-definitions/

No nuclear implosions.

Diff Detail

Repository
rP Phorge
Branch
config-field-people
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1005
Build 1005: arc lint + arc unit

Event Timeline

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...

This revision is now accepted and ready to land.Jan 13 2024, 02:37