Fix reentrancy guard in setDebugTimeLimit()
ClosedPublic
Actions

Authored by • l2dy on Nov 12 2023, 18:12.

Tags

None

Referenced Files

	F3605221: D25469.1745257985.diff
	Sun, Apr 20, 17:53

	F3604555: D25469.1745210754.diff
	Sun, Apr 20, 04:45

	F3553336: D25469.1744929014.diff
	Wed, Apr 16, 22:30

	F3531763: D25469.1744884635.diff
	Wed, Apr 16, 10:10

	F3531169: D25469.1744880445.diff
	Wed, Apr 16, 09:00

	F3509692: D25469.1744803520.diff
	Tue, Apr 15, 11:38

	F3493432: D25469.1744785703.diff
	Tue, Apr 15, 06:41

	F3476698: D25469.1744759206.diff
	Mon, Apr 14, 23:20

Subscribers

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Commits

rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit()

Summary

$initialized is never initialized and onDebugTick() may be registered multiple times.

Test Plan

None. The function is normally only called once.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• l2dy created this revision.Nov 12 2023, 18:12

Owners added a reviewer: O1: Blessed Committers.Nov 12 2023, 18:12

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 12 2023, 18:12

• l2dy requested review of this revision.Nov 12 2023, 18:12

Harbormaster completed remote builds in B917: Diff 1488.Nov 12 2023, 18:13

speck accepted this revision.Nov 12 2023, 21:00

This revision is now accepted and ready to land.Nov 12 2023, 21:00

Closed by commit rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit(). · Explain WhyNov 13 2023, 00:51

This revision was automatically updated to reflect the committed changes.

• l2dy added a commit: rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit().

Revision Contents
Changeset List

Path

Size

Packages

support/

startup/

PhabricatorStartup.php

3 lines

O1: Blessed Committers

Diff 1494

View Options

support/startup/PhabricatorStartup.php

Fix reentrancy guard in setDebugTimeLimit()ClosedPublicActions