Differential D26091

Remove remaining calls to discontinued APC
AcceptedPublic
Actions

Authored by aklapper on Sun, Jun 15, 10:18.

Details

Reviewers

mainframe98

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16116: Remove remnants of PHP APC

Summary

Followup to rP3f5f18a8d6ee7e67e45842b2e63b6485283ee42a. No clue why I missed all this stuff at that time.

APC saw its last release in 2012.
It has been discontinued as PHP 5.5+ includes OpCache.
It has been superseded by APCu for object caching.
See https://pecl.php.net/package-info.php?package=APC

Phorge requires PHP 7.2.
Thus remove remaining calls to APC functions.

The PHP documentation does not even include APC functions anymore, you need to visit web archives, for example:

Closes T16116

Test Plan

Same as rP3f5f18a8d6ee7e67e45842b2e63b6485283ee42a, I assume.

Diff Detail

Repository

rP Phorge

Branch

apcPart2 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2112
Build 2112: arc lint + arc unit

Event Timeline

aklapper created this revision.Sun, Jun 15, 10:18

Owners added a reviewer: O1: Blessed Committers.Sun, Jun 15, 10:18

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSun, Jun 15, 10:18

aklapper requested review of this revision.Sun, Jun 15, 10:18

Harbormaster completed remote builds in B2112: Diff 3241.Sun, Jun 15, 10:18

mainframe98 accepted this revision.Sun, Jun 15, 12:09

This revision is now accepted and ready to land.Sun, Jun 15, 12:09

Please attach revisions to a relevant task, it's sometimes hard to follow the trail.

@avivey: Done. Sorry, I'll try to get better in that. (That subjective threshold between "a quick simple patch" and "a proper task" sometimes drifts too far indeed.)