Differential D25469

Fix reentrancy guard in setDebugTimeLimit()
ClosedPublic
Actions

Authored by • l2dy on Nov 12 2023, 18:12.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Commits

rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit()

Summary

$initialized is never initialized and onDebugTick() may be registered multiple times.

Test Plan

None. The function is normally only called once.

Diff Detail

Repository

rP Phorge

Branch

fix/init-check

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 917
Build 917: arc lint + arc unit

Event Timeline

• l2dy created this revision.Nov 12 2023, 18:12

Owners added a reviewer: O1: Blessed Committers.Nov 12 2023, 18:12

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 12 2023, 18:12

• l2dy requested review of this revision.Nov 12 2023, 18:12

Harbormaster completed remote builds in B917: Diff 1488.Nov 12 2023, 18:13

speck accepted this revision.Nov 12 2023, 21:00

This revision is now accepted and ready to land.Nov 12 2023, 21:00

Closed by commit rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit(). · Explain WhyNov 13 2023, 00:51

This revision was automatically updated to reflect the committed changes.

• l2dy added a commit: rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit().

Revision Contents
Changeset List

Path

Size

Packages

support/

startup/

PhabricatorStartup.php

3 lines

O1: Blessed Committers

Diff 1488

View Options

support/startup/PhabricatorStartup.php

Fix reentrancy guard in setDebugTimeLimit()ClosedPublicActions