Fix regression in DiffusionDiffQueryConduitAPIMethod
ClosedPublic
Actions

Authored by valerio.bozzolan on Oct 2 2023, 14:51.

Details

Reviewers

avivey
speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected

Commits

rPf727f17bc24a: Fix regression in DiffusionDiffQueryConduitAPIMethod

Summary

Fix the following error you may encounter in production:

Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in /var/www/phorge/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected

It was caused by the lack of a new mandatory parameter in a method.

Closes T15649

Test Plan

Check with your big eyes that a ConduitAPIRequest is passed to getDefaultParser().

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 857
Build 857: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Oct 2 2023, 14:51

Owners added a reviewer: O1: Blessed Committers.Oct 2 2023, 14:51

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptOct 2 2023, 14:51

valerio.bozzolan requested review of this revision.Oct 2 2023, 14:51

Harbormaster completed remote builds in B857: Diff 1405.Oct 2 2023, 14:51

valerio.bozzolan edited the test plan for this revision. (Show Details)Oct 2 2023, 14:52

valerio.bozzolan mentioned this in Z1: Phorge.Oct 9 2023, 19:51

valerio.bozzolan added inline comments.

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
222	(See this signature)

lgtm

This revision is now accepted and ready to land.Oct 10 2023, 01:12

Closed by commit rPf727f17bc24a: Fix regression in DiffusionDiffQueryConduitAPIMethod. · Explain WhyOct 10 2023, 05:16

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rPf727f17bc24a: Fix regression in DiffusionDiffQueryConduitAPIMethod.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

conduit/

DiffusionDiffQueryConduitAPIMethod.php

2 lines

O1: Blessed Committers

Diff 1405

View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

Fix regression in DiffusionDiffQueryConduitAPIMethodClosedPublicActions