Page MenuHomePhorge
Differential D25444

Fix regression in DiffusionDiffQueryConduitAPIMethod
ClosedPublic
Actions

Authored by valerio.bozzolan on Oct 2 2023, 14:51.

Details

Reviewers
avivey
speck
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15649: Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected
Commits
rPf727f17bc24a: Fix regression in DiffusionDiffQueryConduitAPIMethod
Summary

Fix the following error you may encounter in production:

Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in /var/www/phorge/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected

It was caused by the lack of a new mandatory parameter in a method.

Closes T15649

Test Plan

Check with your big eyes that a ConduitAPIRequest is passed to getDefaultParser().

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 857
Build 857: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
applications/
diffusion/
conduit/
2 linesO1: Blessed Committers

Diff 1405

View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0