This broadens the typeahead datasource search for repos. Before this patch a repository named "Alligator Simulator" would not be found with the search string "simu...". This is patched with the ferret engine search and indexing features.
See T15583
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15583: Typeahead datasource query for repos should match substrings
- Commits
- rPdc10a7e69ea3: Implement ferret engine in typeahead datasource query for repos
Create repositories with titles with 2 or more words. Search for these repos with the global typeahead search. The search term should begin with the second/third/n-th word of the repo title.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15583
- Lint
Lint Warnings Severity Location Code Message Warning resources/sql/autopatches/20230902.repository.01.rebuild-index.php: CHMOD1 Invalid Executable Warning src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php: CHMOD1 Invalid Executable Warning src/applications/repository/query/PhabricatorRepositoryQuery.php: CHMOD1 Invalid Executable Warning src/applications/repository/search/PhabricatorRepositoryFulltextEngine.php: CHMOD1 Invalid Executable Warning src/applications/repository/search/PhabricatorRepositoryFulltextEngine.php:11 XHP9 Naming Conventions Warning src/applications/repository/search/PhabricatorRepositoryFulltextEngine.php:17 XHP9 Naming Conventions Warning src/applications/repository/search/PhabricatorRepositoryFulltextEngine.php:18 XHP9 Naming Conventions Warning src/applications/repository/search/PhabricatorRepositoryFulltextEngine.php:21 XHP9 Naming Conventions - Unit
Test Failures - Build Status
Buildable 826 Build 826: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 0 ms | PhabricatorCelerityTestCase::testCelerityMaps EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'
#0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703)
#1 /var/www/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
| |
| 0 ms | PhabricatorConduitTestCase::testConduitMethods EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'
#0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703)
#1 /var/www/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
| |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'
#0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703)
#1 /var/www/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
| |
| 0 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'
#0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703)
#1 /var/www/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
| |
| 0 ms | PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'
#0 [internal function]: PhutilErrorHandler::handleError(2, '...', '...', 703)
#1 /var/www/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
| |
| View Full Test Results (7 Failed) |
