Page MenuHomePhorge
Differential D25417

Fix RuntimeException: min(): Array must contain at least one element
ClosedPublic
Actions

Authored by aklapper on Aug 22 2023, 09:09.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15623: RuntimeException: min(): Array must contain at least one element at DiffusionBlameController.php:201
Commits
rPbeec08e01913: Fix RuntimeException: min(): Array must contain at least one element
Summary

Make sure that $epochs[] is never empty but contains 0 so min($epochs) will not complain.

Closes T15623

Test Plan

Carefully read the code (as I am unaware of reproduction steps).

Diff Detail

Repository
rP Phorge
Branch
T15623min (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 798
Build 798: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 22 2023, 09:09
Owners added a reviewer: O1: Blessed Committers.Aug 22 2023, 09:09
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 22 2023, 09:09
aklapper requested review of this revision.Aug 22 2023, 09:09
Harbormaster completed remote builds in B797: Diff 1320.Aug 22 2023, 09:09
aklapper updated this revision to Diff 1321.Aug 22 2023, 09:12

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

Harbormaster completed remote builds in B798: Diff 1321.Aug 22 2023, 09:13
aklapper added a comment.Aug 22 2023, 09:15

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

aklapper updated this revision to Diff 1322.Aug 22 2023, 09:17

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

Harbormaster completed remote builds in B799: Diff 1322.Aug 22 2023, 09:17
aklapper updated this revision to Diff 1323.Aug 22 2023, 09:20

shrug

Harbormaster completed remote builds in B800: Diff 1323.Aug 22 2023, 09:20
avivey accepted this revision.Aug 22 2023, 09:27
This revision is now accepted and ready to land.Aug 22 2023, 09:27
avivey added a comment.Aug 22 2023, 09:27

whatcouldgowrong

Closed by commit rPbeec08e01913: Fix RuntimeException: min(): Array must contain at least one element. · Explain WhyAug 22 2023, 16:31
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPbeec08e01913: Fix RuntimeException: min(): Array must contain at least one element.

Revision Contents
Changeset List

Diff 1321

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0