Differential D25362
Show more in Application Detail and List view Authored by Matthew on Jul 28 2023, 15:32. Tags None Referenced Files
Tokens
Details
Update the Application Detail view and List View to show a unified set of Badges (Deprecated, etc.), show PHIDs and Monograms on the Application Detail view, allow Applications to register Monograms. Example of the page /applications/view/PhabricatorDiffusionApplication/: 
Diff Detail
Event TimelineComment Actions Uh nice!
Comment Actions I'm not really opinionated in indentation but it seems the majority of the lines are indented with 4 spaces instead of two
Comment Actions Unfortunately, PHPStorm defaults to four spaces. I'm not really willing to spend a ton of time arguing with it (especially since my day job requires four spaces) ... though it would be helpful if we could come up with some clear code rules and them implement them in the repository using phpcs. Comment Actions Can I amend this change fixing spaces? I have some time to waste right now and I love this kind of "del del del" ihih
Comment Actions I thought we had "2 spaces" and the rest encoded as lints... I'll try to take a look.
Comment Actions Please wait more feedback from avivey, but I wanted to say that I tested this and I love it Comment Actions I’m surprised the monograms weren’t already defined on the applications - those should be somewhere already, right? Would it be a small change if the display of PHIDs could be in a list or new lines instead of comma-separated? What are thoughts on adding an editorconfig file to the repos? Nearly every editor obeys or has a plug-in for it and would help avoid indentation inconsistencies. I use it in my setups to help manage the indentation prefs between my personal work and work for day job. Comment Actions Due to some weird SSH configuration issues, I can't land right now. So yes, feel free to land it if we get the code review passed. I dug, and they are not, aside from the regex in getRoutes. Seems to be a simple change, let me make that real quick... I am very not familiar with editorconfig, but that seems to be the right tool for the job. It's a bit outside of the scope of these changes, but I would gladly review a revision to introduce it. Comment Actions I cannot double-accept but I like this even more (edited: uh! It seems I can double-accept) Comment Actions Premising that I love your new list of PHIDs: We may want to evaluate whenever to render a more friendly table. Example:
Comment Actions Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context. Comment Actions That would be a good idea... PHIDs are defined by applications so it makes sense to update that wording in the future. I did just land this change though... I'll make a new diff in the future. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
