Paths

Table of Contentst

Differential D25350

Fix tab complete in php 8
ClosedPublic
Actions

Authored by avivey on Jul 15 2023, 19:23.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15064: Make Phorge compatible with PHP 8.1/8.2/8.3

Commits

rARC8a2cb75d6308: Fix tab complete in php 8

Summary

Ref T15064

Test Plan

run arc shell-complete; arc shell-complete arc shell; Should suggest completions, not crash.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 671
Build 671: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 15 2023, 19:23

Owners added a reviewer: O1: Blessed Committers.Jul 15 2023, 19:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 15 2023, 19:23

avivey requested review of this revision.Jul 15 2023, 19:23

Harbormaster completed remote builds in B671: Diff 1124.Jul 15 2023, 19:23

mainframe98 subscribed.Jul 16 2023, 11:44

valerio.bozzolan added inline comments.Jul 18 2023, 07:36

src/toolset/workflow/ArcanistShellCompleteWorkflow.php
95	Finally we can remove the `(bool)`

remove bool

Harbormaster completed remote builds in B682: Diff 1144.Jul 18 2023, 15:18

avivey marked an inline comment as done.Jul 18 2023, 15:40

Thanks :) tested

lgtm

This revision is now accepted and ready to land.Jul 21 2023, 10:16

Closed by commit rARC8a2cb75d6308: Fix tab complete in php 8. · Explain WhyJul 21 2023, 16:46

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rARC8a2cb75d6308: Fix tab complete in php 8.

Revision Contents
Changeset List

Path

Size

Packages

src/

toolset/

workflow/

ArcanistShellCompleteWorkflow.php

2 lines

O1: Blessed Committers

Diff 1124

View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Fix tab complete in php 8ClosedPublicActions