Page MenuHomePhorge

Fix tab complete in php 8
ClosedPublic

Authored by avivey on Jul 15 2023, 19:23.

Details

Summary

Ref T15064

Test Plan

run arc shell-complete; arc shell-complete arc shell; Should suggest completions, not crash.

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D25350
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 682
Build 682: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Jul 15 2023, 19:23
src/toolset/workflow/ArcanistShellCompleteWorkflow.php
95

Finally we can remove the (bool)

avivey marked an inline comment as done.Jul 18 2023, 15:40
This revision is now accepted and ready to land.Jul 21 2023, 10:16
This revision was automatically updated to reflect the committed changes.