Page MenuHomePhorge

Fix tab complete in php 8
ClosedPublic

Authored by avivey on Jul 15 2023, 19:23.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 13, 14:38
Unknown Object (File)
Sat, Jul 13, 14:38
Unknown Object (File)
Sat, Jul 13, 14:38
Unknown Object (File)
Sat, Jul 13, 00:40
Unknown Object (File)
Sat, Jul 13, 00:40
Unknown Object (File)
Thu, Jul 11, 00:06
Unknown Object (File)
Wed, Jul 10, 09:49
Unknown Object (File)
Wed, Jul 10, 09:46

Details

Summary

Ref T15064

Test Plan

run arc shell-complete; arc shell-complete arc shell; Should suggest completions, not crash.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 671
Build 671: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Jul 15 2023, 19:23
src/toolset/workflow/ArcanistShellCompleteWorkflow.php
95

Finally we can remove the (bool)

avivey marked an inline comment as done.Jul 18 2023, 15:40
This revision is now accepted and ready to land.Jul 21 2023, 10:16
This revision was automatically updated to reflect the committed changes.