Paths

Table of Contentst

Do not crop user avatar image in top bar when no Real Name set
ClosedPublic
Actions

Authored by aklapper on Jul 14 2023, 09:35.

Details

Reviewers

Cigaryno
avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15552: User avatar image cropped in top bar when no Real Name set

Commits

rP682fe971a4a9: Do not crop user avatar image in top bar when no Real Name set

Summary

Increase required height for avatar image

Patch provided by Stang in https://phabricator.wikimedia.org/T307492

Closes T15552

Test Plan

Set /config/edit/user.require-real-name/ to Make real names optional
Log in as a user without a real name set
Open the user menu in the top bar and look at the user avatar image

Diff Detail

Repository

rP Phorge

Branch

T15552AvatarCrop (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 669
Build 669: arc lint + arc unit

Event Timeline

aklapper created this revision.Jul 14 2023, 09:35

Owners added a reviewer: O1: Blessed Committers.Jul 14 2023, 09:35

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 14 2023, 09:35

aklapper requested review of this revision.Jul 14 2023, 09:35

Harbormaster completed remote builds in B669: Diff 1121.Jul 14 2023, 09:35

You need to run bin/celerity map after changing a css file.

Cigaryno accepted this revision.Jul 17 2023, 08:51

Ran ./bin/celerity map

Harbormaster completed remote builds in B672: Diff 1125.Jul 17 2023, 09:34

avivey accepted this revision.Jul 17 2023, 09:39

This revision is now accepted and ready to land.Jul 17 2023, 09:39

Closed by commit rP682fe971a4a9: Do not crop user avatar image in top bar when no Real Name set. · Explain WhyJul 17 2023, 10:03

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP682fe971a4a9: Do not crop user avatar image in top bar when no Real Name set.

Revision Contents
Changeset List

Path

Size

Packages

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-simple-ui.css

2 lines

O1: Blessed Committers

Diff 1121

View Options

webroot/rsrc/css/phui/object-item/phui-oi-simple-ui.css

Do not crop user avatar image in top bar when no Real Name setClosedPublicActions