Page MenuHomePhorge

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()
ClosedPublic

Authored by Sten on Jul 7 2023, 14:36.
Tags
None
Referenced Files
F2982804: D25340.1739971893.diff
Tue, Feb 18, 13:31
F2982772: D25340.1739971814.diff
Tue, Feb 18, 13:30
F2982458: D25340.1739960376.diff
Tue, Feb 18, 10:19
F2971316: D25340.1739539635.diff
Thu, Feb 13, 13:27
F2970944: D25340.1739533818.diff
Thu, Feb 13, 11:50
F2949969: D25340.1738700552.diff
Mon, Feb 3, 20:22
F2943538: D25340.1738199952.diff
Wed, Jan 29, 01:19
F2943520: D25340.1738198243.diff
Wed, Jan 29, 00:50

Details

Summary

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Fixes T15542

Test Plan
  1. Go into a diff (eg https://my.phorge.site/D1234)
  2. Click on the Revision Contents - History tab
  3. Click on a base link (the short git revision ID)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Jul 7 2023, 14:36
src/applications/diffusion/view/DiffusionView.php
71

Can't default $display_name to '' due to the explicit null check on line 106.

This revision is now accepted and ready to land.Jul 11 2023, 08:19