Differential D25340

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()
ClosedPublic
Actions

Authored by Sten on Jul 7 2023, 14:36.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15542: Fix strlen(null) when viewing a diff by git commit ID under PHP 8.1

Commits

rP3703588e9db6: Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()

Summary

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Fixes T15542

Test Plan

Go into a diff (eg https://my.phorge.site/D1234)
Click on the Revision Contents - History tab
Click on a base link (the short git revision ID)

Diff Detail

Repository

rP Phorge

Branch

DiffusionCommitController (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 657
Build 657: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 7 2023, 14:36

Owners added a reviewer: O1: Blessed Committers.Jul 7 2023, 14:36

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 7 2023, 14:36

Sten requested review of this revision.Jul 7 2023, 14:36

Harbormaster completed remote builds in B657: Diff 1105.Jul 7 2023, 14:37

Sten added inline comments.Jul 7 2023, 14:38

src/applications/diffusion/view/DiffusionView.php
71	Can't default $display_name to '' due to the explicit null check on line 106.

avivey accepted this revision.Jul 11 2023, 08:19

This revision is now accepted and ready to land.Jul 11 2023, 08:19

Closed by commit rP3703588e9db6: Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse(). · Explain WhyJul 12 2023, 12:38

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP3703588e9db6: Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

view/

DiffusionView.php

2 lines

O1: Blessed Committers

Diff 1105

View Options

src/applications/diffusion/view/DiffusionView.php

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()ClosedPublicActions