Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F2936817: D25306.1737940473.diff
Sun, Jan 26, 01:14
F2933495: D25306.1737771791.diff
Fri, Jan 24, 02:23
F2933384: D25306.1737765290.diff
Fri, Jan 24, 00:34
F2933383: D25306.1737765228.diff
Fri, Jan 24, 00:33
F2933382: D25306.1737765221.diff
Fri, Jan 24, 00:33
F2933348: D25306.1737763382.diff
Fri, Jan 24, 00:03
F2919106: D25306.1737533847.diff
Tue, Jan 21, 08:17
F2918881: D25306.1737530867.diff
Tue, Jan 21, 07:27

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable