Page MenuHomePhorge

Diffusion commits: add some edge phrases about Revisions
ClosedPublic

Authored by valerio.bozzolan on Jun 22 2023, 14:28.
Tags
None
Referenced Files
F3151875: D25306.1741226891.diff
Wed, Mar 5, 02:08
F3151874: D25306.1741226889.diff
Wed, Mar 5, 02:08
F3089141: D25306.1741087704.diff
Mon, Mar 3, 11:28
F2982488: D25306.1739960406.diff
Tue, Feb 18, 10:20
F2963324: D25306.1739204000.diff
Sun, Feb 9, 16:13
F2961173: D25306.1739161654.diff
Sun, Feb 9, 04:27
F2961172: D25306.1739161649.diff
Sun, Feb 9, 04:27
F2961171: D25306.1739161644.diff
Sun, Feb 9, 04:27

Details

Summary

This change implements some messages that were only present
from this class:

DifferentialRevisionHasCommitEdgeType.php

But not in its inverse class:

DiffusionCommitHasRevisionEdgeType.php

In short:

BeforeAfter
BEFORE.png (249×868 px, 42 KB)
AFTER.png (249×868 px, 44 KB)

Closes T15314

Test Plan

Visit a Diffusion commit and use the sidebar menu "Edit Related Objects" to:

  • add 1 revision
  • add 2 revisions
  • remove 1 revision
  • remove 2 revisions
  • add 1 revision, remove 1 revision
  • add 2 revisions, remove 2 revisions

Check that you don't see phrases like "added an edge" anymore.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable