Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error
ClosedPublic
Actions

Authored by Sten on Jul 3 2023, 16:43.

Details

Reviewers

valerio.bozzolan
avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15518: PHP 8.1 trim(NULL) error in PhabricatorEditorURIEngine::newForViewer()

Commits

rP65e57fe23dd3: Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error

Summary

Under PHP 8.1, PhabricatorEditorURIEngine::newForViewer() is throwing a trim(NULL) error when trying to view a diff.
This is because it tries to apply string operations to a user setting which will be null by default.

Fixes T15518

Test Plan

Unit test added -

arc unit

Or just view a diff. Eg:
https://my.phorge.site/D1234

Diff Detail

Repository

rP Phorge

Branch

PhabricatorEditorURIEngineTrim (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 623
Build 623: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 3 2023, 16:43

Owners added a reviewer: O1: Blessed Committers.Jul 3 2023, 16:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 3 2023, 16:43

Sten requested review of this revision.Jul 3 2023, 16:43

Harbormaster completed remote builds in B623: Diff 1053.Jul 3 2023, 16:43

valerio.bozzolan added inline comments.Jul 5 2023, 11:26

src/infrastructure/editor/PhabricatorEditorURIEngine.php
19	Since we are not interested in knowing the length of the string. Also note that `trim()` always return a string, and never NULL.
19	Premising that your addition of `$pattern === null` is perfectly OK ✅