Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
ClosedPublic

Authored by aklapper on May 15 2024, 12:33.
Tags
None
Referenced Files
F3296158: D25639.1742969536.diff
Tue, Mar 25, 06:12
F3294328: D25639.1742933303.diff
Mon, Mar 24, 20:08
F3291614: D25639.1742879340.diff
Mon, Mar 24, 05:09
F3249506: D25639.1742286382.diff
Mon, Mar 17, 08:26
F3212713: D25639.1741468257.diff
Fri, Mar 7, 21:10
F3212685: D25639.1741464580.diff
Fri, Mar 7, 20:09
F3010048: D25639.1740626532.diff
Wed, Feb 26, 03:22
F3010047: D25639.1740626532.diff
Wed, Feb 26, 03:22

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/controller/PhabricatorAuthStartController.php:34]

Closes T15832

Test Plan

Run arc unit locally, probably also don't be logged in.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable