Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
ClosedPublic

Authored by aklapper on Wed, May 15, 12:33.
Tags
None
Referenced Files
F2197036: D25639.1716237803.diff
Sun, May 19, 20:43
Unknown Object (File)
Sat, May 18, 17:58
Unknown Object (File)
Sat, May 18, 15:57
Unknown Object (File)
Fri, May 17, 17:22

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/controller/PhabricatorAuthStartController.php:34]

Closes T15832

Test Plan

Run arc unit locally, probably also don't be logged in.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable