Remove setup check for PHP 7.0
ClosedPublic
Actions

Authored by aklapper on Sat, Apr 5, 13:44.

Tags

None

Referenced Files

	F3522989: D25948.1744816690.diff
	Tue, Apr 15, 15:18

	F3397457: D25948.1744528647.diff
	Sat, Apr 12, 07:17

	F3395916: D25948.1744519137.diff
	Sat, Apr 12, 04:38

	F3394330: D25948.1744504621.diff
	Sat, Apr 12, 00:37

	F3391860: D25948.1744483300.diff
	Fri, Apr 11, 18:41

	F3387661: D25948.1744439955.diff
	Fri, Apr 11, 06:39

	F3387300: D25948.1744434501.diff
	Fri, Apr 11, 05:08

	F3385215: D25948.1744412668.diff
	Thu, Apr 10, 23:04

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15047: Officially raise minimum required PHP version to 7.2

Commits

rPadc199eb4abb: Remove setup check for PHP 7.0

Summary

Phorge requires PHP 7.2 so don't check for PHP 7.0.

Test Plan

Set up Phorge, I guess.

Diff Detail

Repository

rP Phorge

Branch

rmPhp71check (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1843
Build 1843: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, Apr 5, 13:44

Owners added a reviewer: O1: Blessed Committers.Sat, Apr 5, 13:44

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Apr 5, 13:44

aklapper requested review of this revision.Sat, Apr 5, 13:44

Harbormaster completed remote builds in B1843: Diff 2835.Sat, Apr 5, 13:44

sgtm

This revision is now accepted and ready to land.Sat, Apr 5, 13:57

Closed by commit rPadc199eb4abb: Remove setup check for PHP 7.0. · Explain WhySat, Apr 5, 14:02

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPadc199eb4abb: Remove setup check for PHP 7.0.

Cigaryno mentioned this in Z1: Phorge.Sat, Apr 5, 16:06

valerio.bozzolan mentioned this in Next Up.Sat, Apr 5, 17:30

valerio.bozzolan added a task: T15047: Officially raise minimum required PHP version to 7.2.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

25 lines

O1: Blessed Committers

Diff 2835

View Options

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Remove setup check for PHP 7.0ClosedPublicActions