Remove the onboard "mailKey" from Paste
Needs ReviewPublic
Actions

Authored by mainframe98 on Thu, Feb 27, 19:16.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

See T13065 and rP1e2bc7775bc4.

Intended to cover the gap left by D25899.
The actual amount of impacted installations should
be 0, but the migration makes sure all pastes have
a mail key regardless.

Test Plan

Create a paste
Run ./bin/storage upgrade
Check that the mailkey is in the new table correctly

Diff Detail

Repository

rP Phorge

Branch

migrate-paste-to-mailkey-table

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1752
Build 1752: arc lint + arc unit

Event Timeline

mainframe98 created this revision.Thu, Feb 27, 19:16

Owners added a reviewer: O1: Blessed Committers.Thu, Feb 27, 19:16

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, Feb 27, 19:16

mainframe98 requested review of this revision.Thu, Feb 27, 19:16

Harbormaster completed remote builds in B1752: Diff 2705.Thu, Feb 27, 19:16

mainframe98 mentioned this in D25899: Rebuild quickstart.sql.Thu, Feb 27, 19:19

You know better than me the context. Is there a possibility that an installation is already without that column?

If you think yes, maybe DROP COLUMN IF EXISTS

resources/sql/autopatches/20250227.paste.02.mailkey.sql
2	I think the canonical way is `DROP COLUMN`

In D25900#24197, @valerio.bozzolan wrote:

You know better than me the context. Is there a possibility that an installation is already without that column?

Theoretically, yes, but in practice no, provided they ran storage upgrade. After a certain point, the deprecations in newer PHP versions would prevent you from running the migrations anyway. Afterwards, the paste table would have been renamed, breaking the upgrade entirely.

(Also I forgot to drop the column from PhabricatorPaste - whoops)