See rPaaab1011e5a464ea94c182001a7fe867b19bae5a.
AphrontView::setUser() is deprecated.
Save a few CPU cycles and nuclear power plants.
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers
Read the code.
Even better, intentionally introduce an error in AphrontView::setUser()
and browse random Phorge pages and then replace the call accordingly (as
there are numerous setUser() methods across the codebase and we don't
want no explosions).
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- deprecateSetUser (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1706 Build 1706: arc lint + arc unit
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
| src/applications/conpherence/controller/ConpherenceViewController.php | ||
|---|---|---|
| 163 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| src/applications/dashboard/controller/PhabricatorDashboardProfileController.php | ||
| 35 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php | ||
| 78 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| src/applications/differential/controller/DifferentialDiffCreateController.php | ||
| 144 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 181 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| src/applications/differential/controller/DifferentialRevisionViewController.php | ||
| 385 | ✅ DifferentialChangesetListView extends AphrontView (and does not override setUser) | |
| 411 | ✅ DifferentialRevisionUpdateHistoryView extends AphrontView (and does not override setUser) | |
| 419 | ✅ DifferentialLocalCommitsView extends AphrontView (and does not override setUser) | |
| 670 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 727 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| 1203 | ✅ PHUIObjectBoxView extends AphrontView (and does not override setUser) | |
| 1214 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/differential/customfield/DifferentialReviewersField.php | ||
| 42 | ✅ DifferentialReviewersView extends AphrontView (and does not override setUser) | |
| src/applications/diffusion/controller/DiffusionRepositoryController.php | ||
| 277 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 318 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 362 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php | ||
| 182 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/feed/builder/PhabricatorFeedBuilder.php | ||
| 63 | 🔶 probably cannot be tested statically - cute test plan needed | |
| src/applications/files/controller/PhabricatorFileUploadController.php | ||
| 57 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 71 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| 89 | ✅ PhabricatorGlobalUploadTargetView extends AphrontView (and does not override setUser) | |
| src/applications/files/controller/PhabricatorFileViewController.php | ||
| 39 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php | ||
| 22 | ✅ PhabricatorGlobalUploadTargetView extends AphrontView (and does not override setUser) | |
| src/applications/legalpad/controller/LegalpadDocumentManageController.php | ||
| 46 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 88 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| 151 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/maniphest/controller/ManiphestTaskDetailController.php | ||
| 288 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 457 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/maniphest/query/ManiphestTaskSearchEngine.php | ||
| 382 | ✅ ManiphestTaskResultListView extends AphrontView (and does not override setUser) | |
| src/applications/maniphest/view/ManiphestTaskListView.php | ||
| 61 | ✅ PHUIObjectItemView extends AphrontView (and does not override setUser) | |
| src/applications/maniphest/view/ManiphestTaskResultListView.php | ||
| 68 | ✅ ManiphestTaskListView extends AphrontView (and does not override setUser) | |
| src/applications/meta/controller/PhabricatorApplicationDetailViewController.php | ||
| 31 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| src/applications/meta/controller/PhabricatorApplicationEditController.php | ||
| 82 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 99 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| src/applications/passphrase/controller/PassphraseCredentialEditController.php | ||
| 260 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| src/applications/paste/controller/PhabricatorPasteViewController.php | ||
| 94 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| src/applications/people/controller/PhabricatorPeopleProfileViewController.php | ||
| 93 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| 138 | ✅ PhabricatorProjectListView extends AphrontView (and does not override setUser) | |
| src/applications/pholio/controller/PholioMockEditController.php | ||
| 249 | ✅ PholioUploadedImageView extends AphrontView (and does not override setUser) | |
| 300 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 313 | ✅ PhabricatorRemarkupControl extends AphrontView (and does not override setUser) | |
| 325 | ✅ AphrontFormTokenizerControl extends AphrontView (and does not override setUser) | |
| 329 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| 337 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| src/applications/pholio/controller/PholioMockViewController.php | ||
| 54 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 76 | ✅ PholioMockImagesView extends AphrontView (and does not override setUser) | |
| 92 | ✅ PholioMockThumbGridView extends AphrontView (and does not override setUser) | |
| 179 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| 225 | ✅ PhabricatorApplicationTransactionCommentView extends AphrontView (and does not override setUser) | |
| src/applications/pholio/query/PholioMockSearchEngine.php | ||
| 107 | ✅ PHUIPinboardItemView extends AphrontView (and does not override setUser) | |
Comment Actions
Aaand last 48 lines checked. Differential is crashing in my laptop lol
| src/applications/conpherence/controller/ConpherenceViewController.php | ||
|---|---|---|
| 170 | ✅ PhabricatorRemarkupControl extends AphrontView (and does not override setUser) | |
| src/applications/pholio/view/PholioUploadedImageView.php | ||
| 35 | ✅ PhabricatorRemarkupControl extends AphrontView (and does not override setUser) | |
| src/applications/phriction/query/PhrictionDocumentSearchEngine.php | ||
| 117 | ✅ PHUIObjectItemListView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectBoardViewController.php | ||
| 100 | ✅ PHUIObjectItemListView extends AphrontView (and does not override setUser) | |
| 210 | ✅ PHUIObjectItemListView extends AphrontView (and does not override setUser) | |
| 441 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 544 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 632 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 797 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 859 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectEditPictureController.php | ||
| 110 | ✅ PHUIFormLayoutView extends AphrontView (and does not override setUser) | |
| 264 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectManageController.php | ||
| 23 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 136 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectMembersViewController.php | ||
| 26 | ✅ PhabricatorProjectMemberListView extends AphrontView (and does not override setUser) | |
| 33 | ✅ PhabricatorProjectWatcherListView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectProfileController.php | ||
| 30 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 64 | ✅ PhabricatorProjectMemberListView extends AphrontView (and does not override setUser) | |
| 71 | ✅ PhabricatorProjectWatcherListView extends AphrontView (and does not override setUser) | |
| 163 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| 264 | ✅ PhabricatorProjectListView extends AphrontView (and does not override setUser) | |
| src/applications/project/controller/PhabricatorProjectSubprojectsController.php | ||
| 45 | ✅ PhabricatorProjectListView extends AphrontView (and does not override setUser) | |
| 67 | ✅ PhabricatorProjectListView extends AphrontView (and does not override setUser) | |
| src/applications/project/query/PhabricatorProjectSearchEngine.php | ||
| 328 | ✅ PhabricatorProjectListView extends AphrontView (and does not override setUser) | |
| src/applications/project/view/PhabricatorProjectListView.php | ||
| 47 | ✅ PHUIObjectItemListView extends AphrontView (and does not override setUser) | |
| src/applications/project/view/ProjectBoardTaskCard.php | ||
| 94 | ✅ PHUIObjectItemView extends AphrontView (and does not override setUser) | |
| src/applications/repository/query/PhabricatorRepositorySearchEngine.php | ||
| 178 | ✅ PHUIObjectItemView extends AphrontView (and does not override setUser) | |
| src/applications/search/controller/PhabricatorApplicationSearchController.php | ||
| 181 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 774 | ✅ AphrontSideNavFilterView extends AphrontView (and does not override setUser) | |
| src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php | ||
| 156 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 165 | ✅ PhabricatorRemarkupControl extends AphrontView (and does not override setUser) | |
| 268 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| src/applications/slowvote/controller/PhabricatorSlowvotePollController.php | ||
| 26 | ✅ SlowvoteEmbedView extends AphrontView (and does not override setUser) | |
| 46 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 156 | ✅ PhabricatorApplicationTransactionCommentView extends AphrontView (and does not override setUser) | |
| src/applications/spaces/controller/PhabricatorSpacesEditController.php | ||
| 124 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 148 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| 156 | ✅ AphrontFormPolicyControl extends AphrontView (and does not override setUser) | |
| src/applications/spaces/controller/PhabricatorSpacesViewController.php | ||
| 36 | ✅ PHUIHeaderView extends AphrontView (and does not override setUser) | |
| 75 | ✅ PHUIPropertyListView extends AphrontView (and does not override setUser) | |
| src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php | ||
| 76 | ✅ PHUIObjectItemListView extends AphrontView (and does not override setUser) | |
| src/applications/transactions/editengine/PhabricatorEditEngine.php | ||
| 1287 | ✅ PHUIObjectBoxView extends AphrontView (and does not override setUser) | |
| 1360 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| 1433 | ✅ PhabricatorActionListView extends AphrontView (and does not override setUser) | |
| 1676 | ✅ PhabricatorApplicationTransactionCommentView extends AphrontView (and does not override setUser) | |
| src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php | ||
| 367 | ✅ AphrontFormView extends AphrontView (and does not override setUser) | |
| src/applications/uiexample/examples/PHUIFeedStoryExample.php | ||
| 32 | ✅ PHUIFeedStoryView extends AphrontView (and does not override setUser) | |
| 57 | ✅ PHUIFeedStoryView extends AphrontView (and does not override setUser) | |